-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version to output #427
Conversation
Very weird, but for some reason DuckDB has a bug/issue with rounding a float when using A hack that seems to work is to just not test this column on DuckDB:
|
DuckDB 0.10 is out as well but the bug on the check still exists on the new version |
@b-per @graciegoheen looks like the only failure here is another weird decimal rounding issue in the test:
not sure it's worth fretting about or if this one can just get merged in! |
@dave, could you treat databricks and trino the same way we did for DuckDB so that this particular column is not tested? |
@b-per done! |
@@ -34,6 +34,7 @@ unioned_with_calc as ( | |||
*, | |||
case | |||
when resource_type = 'source' then {{ dbt.concat(['source_name',"'.'",'name']) }} | |||
when version is not null then {{ dbt.concat(['name',"'.v'",'version']) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this vs. a new field called "version"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i add that on line 87!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ope - yes, thank you!
Closes #425
This is a:
Link to Issue
This PR
version
anddeprecation_date
to our unpack macrosmodel.my_project.my_model.v1
would have been identified asmy_model
in all rules in the project before this change, and will be identified asmy_model.v1
after this change.model.my_project.my_unversioned_model
would be identified asmy_unversioned_model
before and after this changeDescription & motivation
This is a more correct representation of the nodes in the project, and disambiguates situations where more than one version of a model violates a rule, or when a versioned model is referenced only by name in a rule output
Integration Test Screenshot
Checklist