-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version to output #427
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
1420383
add versino to unpack macros, recursive sql, and intermediate core mo…
dave-connors-3 ef1fe4e
update uniqueness test
dave-connors-3 8eb5889
add versions to int_model_5
dave-connors-3 935dd94
update direct join to source test
dave-connors-3 aff9157
update hard coded rule
dave-connors-3 dfdfd23
update fanout rule
dave-connors-3 aa106cc
update multiple sources joined
dave-connors-3 1d71283
update docs coverage percentage
dave-connors-3 098fc1e
update root models rule
dave-connors-3 9cbb9f7
interim refactor
dave-connors-3 6926da5
remove version and deprecation date from recursive sql
dave-connors-3 eef7435
amend djtc
dave-connors-3 bc6eaf7
amend hcr
dave-connors-3 03304f5
amend mf
dave-connors-3 a4cae24
amend msj
dave-connors-3 44bce77
update rjuc
dave-connors-3 a14f565
update seed for root models
dave-connors-3 cf6ffd7
update undocumented models seed
dave-connors-3 525a854
fix cvds seed
dave-connors-3 9043d2e
fix remaining seeds, remove version from test calc
dave-connors-3 f67ad76
revert model test summary test
dave-connors-3 52689ea
revert logic change to model test summary
dave-connors-3 1efde31
conditionally exclude check in duckdb due to bug with floats
dave-connors-3 9cde872
Merge branch 'main' into add-version-to-output
dave-connors-3 9cb9ece
Merge branch 'main' into add-version-to-output
dave-connors-3 3c82ad2
Merge branch 'main' into add-version-to-output
graciegoheen 368f776
merge main
dave-connors-3 a357a64
adjust seeds
dave-connors-3 38a0417
update tests for rounding errors
dave-connors-3 6c2bfc1
Merge branch 'main' into add-version-to-output
dave-connors-3 ff36cf1
Merge branch 'main' into add-version-to-output
b-per File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
models: | ||
- name: int_model_5 | ||
latest_version: 2 | ||
versions: | ||
- v: 1 | ||
deprecation_date: 2024-01-01 | ||
- v: 2 | ||
deprecation_date: 2029-01-01 | ||
- v: 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
select 1 as id |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
select 1 as id |
2 changes: 1 addition & 1 deletion
2
integration_tests/seeds/dag/test_fct_rejoining_of_upstream_concepts.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
parent,child,parent_and_child,is_loop_independent | ||
stg_model_1,int_model_5,int_model_4,true | ||
stg_model_1,int_model_5.v2,int_model_4,true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
child | ||
int_model_5.v1 | ||
int_model_5.v3 | ||
model_8 |
2 changes: 1 addition & 1 deletion
2
integration_tests/seeds/docs/test_fct_documentation_coverage.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
total_models,documented_models,documentation_coverage_pct,staging_documentation_coverage_pct,intermediate_documentation_coverage_pct,marts_documentation_coverage_pct,other_documentation_coverage_pct | ||
16,4,25,20.00,0.00,0.00,75.00 | ||
18,4,22.22,20.00,0.00,0.00,75.00 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
total_models,total_tests,tested_models,test_coverage_pct,staging_test_coverage_pct,intermediate_test_coverage_pct,marts_test_coverage_pct,other_test_coverage_pct,test_to_model_ratio | ||
16,13,6,37.50,80.00,50.00,0.00,25.00,0.8125 | ||
18,13,6,33.33,80.00,25.00,0.00,25.00,0.7222 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this vs. a new field called "version"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i add that on line 87!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ope - yes, thank you!