Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enabled pre-commit checks for repository #412

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
version: 2.1

jobs:

integration-postgres:
docker:
- image: cimg/python:3.9.9
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
command: ./run_test.sh snowflake
- store_artifacts:
path: ./integration_tests/logs

integration-bigquery:
environment:
BIGQUERY_SERVICE_KEY_PATH: "/home/circleci/bigquery-service-key.json"
Expand Down
17 changes: 10 additions & 7 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
---

name: Bug report
about: Report a bug or an issue you've found with this package
title: ''
labels: bug, triage
assignees: ''

---
<!-- markdownlint-disable MD002-->

### Describe the bug
<!---
Expand Down Expand Up @@ -33,29 +34,31 @@ If applicable, add screenshots or log output to help explain your problem.
--->

### System information

**The contents of your `packages.yml` file:**

**Which database are you using dbt with?**

- [ ] postgres
- [ ] redshift
- [ ] bigquery
- [ ] snowflake
- [ ] trino/starburst
- [ ] other (specify: ____________)


**The output of `dbt --version`:**
```

```bash
<output goes here>
```


### Additional context
<!---
Add any other context about the problem here. For example, if you think you know which line of code is causing the issue.
Add any other context about the problem here.
For example, if you think, you know which line of code is causing the issue.
--->

### Are you interested in contributing the fix?
<!---
Let us know if you want to contribute the fix, and whether would need a hand getting started
--->
Let us know if you want to contribute the fix, and whether you would need a hand getting started
--->
10 changes: 7 additions & 3 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,26 @@ about: Suggest an idea for this package
title: ''
labels: enhancement, triage
assignees: ''

---
<!-- markdownlint-disable MD002-->

### Describe the feature

A clear and concise description of what you want to happen.

### Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

### Additional context

Is this feature database-specific? Which database(s) is/are relevant? Please include any other relevant context here.

### Who will this benefit?

What kind of use case will this feature be useful for? Please be specific and provide examples, this will help us prioritize properly.

### Are you interested in contributing this feature?
<!---
Let us know if you want to contribute the feature, and whether would need a hand getting started
--->
Let us know if you want to contribute the feature, and whether you would need a hand getting started
--->
25 changes: 14 additions & 11 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
# Pull request

This is a:

- [ ] bug fix PR with no breaking changes
- [ ] new functionality

## Link to Issue
## Link to Issue
<!---
Include this section if you are closing an open issue
e.g.
e.g.
Closes #13
-->


## Description & motivation
<!---
Describe your changes, and why you're making them.
Expand All @@ -21,13 +23,14 @@ Screenshot of passing integration tests locally
-->

## Checklist

- [ ] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
- [ ] BigQuery
- [ ] Postgres
- [ ] Redshift
- [ ] Snowflake
- [ ] Databricks
- [ ] DuckDB
- [ ] Trino/Starburst
- [ ] BigQuery
- [ ] Postgres
- [ ] Redshift
- [ ] Snowflake
- [ ] Databricks
- [ ] DuckDB
- [ ] Trino/Starburst
- [ ] I have updated the README.md (if applicable)
- [ ] I have added tests & descriptions to my models (and macros if applicable)
- [ ] I have added tests & descriptions to my models (and macros if applicable)
18 changes: 18 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
name: ci

on:
pull_request:
push:
branches: [main]

jobs:
pre-commit:
name: 'Pre-commit checks'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.12'
- uses: pre-commit/[email protected]
Loading
Loading