-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt Cloud quickstart guides #2749
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…into ly-docs-bq-gsg
…into ly-docs-bq-gsg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A flock of comments for everything except for Databricks, which I will do separately once Ly's finished tweaking it!
One thing that I wanted to raise: in this, we're encouraging people to set up a basic project; given that the Teams plan only allows a single project, people are going to have to either delete this one when they're done and then make another, or they'll have to tear out their temporary demo connection and rebuild their project to connect to the "correct" warehouse if they didn't from the outset.
Are we giving good/any guidance around that?
title="Quickstart for dbt Core" | ||
body="When you use dbt Core to work with dbt, you will be editing files locally using a code editor, and running projects using a command line interface." | ||
link="/docs/quickstarts/dbt-core/quickstart" | ||
icon="pencil-paper"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool if there was a specialist icon here too, e.g. https://fontawesome.com/icons/square-terminal?s=solid&f=classic
...ite/docs/guides/dbt-ecosystem/databricks-guides/how-to-set-up-your-databricks-dbt-project.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Many of the notes I would have written were dupes of the same comment on the BQ model so any tweaks you make there, remember to apply to the other 3 guides 😅
12. To ensure any users who might be working on your dbt project has access to your object, run this command. | ||
|
||
```sql | ||
grant all privileges on schema default to users; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough to reject this, but it feels like a big hammer to solve a problem. Do we want to encourage people who might not be experienced DBA's to solve their problems with grant all privileges to all users
?
hey @joellabes,
no, it doesn't look like we are at the moment and is a really good point to raise. thank you. i don't think this is a blocker (but lemme know if you think it should be!) but i think is definitely something that should be followed up (added this to my list). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nghi-ly I read the overview and have some tiny suggestions. It reads super nicely and I expect it to really help users get started!! Nice work!
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nghi-ly a tiny suggestion non-blocking and we should capture Joel's unaddressed thoughts in follow up issues.
first_name, | ||
last_name | ||
|
||
from `dbt-tutorial`.jaffle_shop.customers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nghi-ly maybe you can create a follow-up issue to address Joel's comment here.
Co-authored-by: Leona B. Campbell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving this the final
What are you changing in this pull request and why?
Similar to the dbt Core get started, update the dbt Cloud get started guides such that the Building your first models, Test and document your project, and Schedule a job are not on separate pages. After the update, the guides would be:
Rename "Getting started with dbt Core" to "Quickstart for dbt Core"
Checklist
Adding new pages (delete if not applicable):
website/sidebars.js
Removing or renaming existing pages (delete if not applicable):
website/sidebars.js
_redirects