-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dbt-watsonx-presto setup and config files #6736
Conversation
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
@KNagaVivek is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
website/docs/docs/core/connect-data-platform/watsonx-presto-setup.md
Outdated
Show resolved
Hide resolved
website/docs/docs/core/connect-data-platform/watsonx-presto-setup.md
Outdated
Show resolved
Hide resolved
website/docs/docs/core/connect-data-platform/watsonx-presto-setup.md
Outdated
Show resolved
Hide resolved
website/docs/reference/resource-configs/watsonx-presto-config.md
Outdated
Show resolved
Hide resolved
website/docs/reference/resource-configs/watsonx-presto-config.md
Outdated
Show resolved
Hide resolved
website/docs/reference/resource-configs/watsonx-presto-config.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this! I have a few comments to ensure clarity in the documentation.
I was also curious if the adapter supports iceberg table format?
f443241
to
53a9257
Compare
Update the docs according to the review comments.
Yes, it does. I’ve included the relevant details in the documentation using a |
website/docs/docs/core/connect-data-platform/watsonx-presto-setup.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @amychen1776
Thanks for this. This was a great read. I've approved this for you and left a few non-blocking suggestions.
Note - there were some vercel failures relating to the sidebar so I updated (with Mirna's help) the sidebar name to resolve those.
Kind Regards
Natalie
…tup.md Co-authored-by: nataliefiann <[email protected]>
…tup.md Co-authored-by: nataliefiann <[email protected]>
…tup.md Co-authored-by: nataliefiann <[email protected]>
…tup.md Co-authored-by: nataliefiann <[email protected]>
…tup.md Co-authored-by: nataliefiann <[email protected]>
…tup.md Co-authored-by: nataliefiann <[email protected]>
…tup.md Co-authored-by: nataliefiann <[email protected]>
…tup.md Co-authored-by: nataliefiann <[email protected]>
Thanks @nataliefiann for the review! It was all @KNagaVivek 's work :) |
@amychen1776 i think need to remove this line
as it doesn't. have cloud support |
Head branch was pushed to by a user without write access
@amychen1776 removed the
and pushed the changes. |
What are you changing in this pull request and why?
Adding dbt-watsonx-presto setup and config files since dbt-watsonx-presto adapter
Checklist