Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dbt-watsonx-presto setup and config files #6736

Merged
merged 37 commits into from
Jan 23, 2025

Conversation

KNagaVivek
Copy link
Contributor

What are you changing in this pull request and why?

Adding dbt-watsonx-presto setup and config files since dbt-watsonx-presto adapter

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

Copy link

welcome bot commented Jan 8, 2025

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 8, 2025

@KNagaVivek is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 8, 2025
@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Jan 8, 2025
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 23, 2025 2:33pm

@amychen1776 amychen1776 self-assigned this Jan 9, 2025
@KNagaVivek KNagaVivek marked this pull request as ready for review January 10, 2025 01:50
@KNagaVivek KNagaVivek requested a review from a team as a code owner January 10, 2025 01:50
Copy link
Collaborator

@amychen1776 amychen1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this! I have a few comments to ensure clarity in the documentation.

I was also curious if the adapter supports iceberg table format?

@KNagaVivek KNagaVivek force-pushed the current branch 3 times, most recently from f443241 to 53a9257 Compare January 15, 2025 03:53
@KNagaVivek
Copy link
Contributor Author

@amychen1776

Update the docs according to the review comments.

I was also curious if the adapter supports iceberg table format?

Yes, it does. I’ve included the relevant details in the documentation using a config block. Additionally, if an Iceberg catalog is configured in watsonx.data, it can be specified in the profiles.yml file to enable the creation and management of Iceberg tables.

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @amychen1776

Thanks for this. This was a great read. I've approved this for you and left a few non-blocking suggestions.

Note - there were some vercel failures relating to the sidebar so I updated (with Mirna's help) the sidebar name to resolve those.

Kind Regards
Natalie

@amychen1776
Copy link
Collaborator

Thanks @nataliefiann for the review! It was all @KNagaVivek 's work :)

@amychen1776 amychen1776 enabled auto-merge January 23, 2025 13:48
@KNagaVivek
Copy link
Contributor Author

KNagaVivek commented Jan 23, 2025

@amychen1776 i think need to remove this line

<Snippet path="warehouse-setups-cloud-callout" />

as it doesn't. have cloud support

auto-merge was automatically disabled January 23, 2025 13:52

Head branch was pushed to by a user without write access

@KNagaVivek
Copy link
Contributor Author

@amychen1776 removed the

<Snippet path="warehouse-setups-cloud-callout" />

and pushed the changes.

@amychen1776 amychen1776 merged commit 1c6f692 into dbt-labs:current Jan 23, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants