Allow for a one-line representation in mf_pformat_dict()
#1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| total_value_length += len(value_str) | ||
|
|
||
| one_line_length = ( | ||
| len(description or "") + 1 + 2 + 2 * len(str_converted_dict) + total_key_length + total_value_length |
There was a problem hiding this comment.
what is this + 1 + 2 + 2? what do you think about making them variables or constants to make it clear what is their purpose?
There was a problem hiding this comment.
They're the lengths of the required () and , . But seeing as it's hard to read, I've updated it to a simpler approach.
courtneyholcomb
approved these changes
Feb 10, 2025
…ct, one-line representation when possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables small objects with a short string representation to be formatted on one line.