Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposition of a different packaging for this project #3

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

matlo607
Copy link

Hi,

Recently, I have been struggling to use your project http-link-header-cpp. I was initially trying to build jsonld-cpp into conan and faced those following issues:

  • header path missing the project name directory, so possible clashes
  • some copy-pasted dependencies inside the project. (uriparser, doctest)
  • the cmake script has assumptions about how the dependencies are exposed which makes the export of the artifacts difficult in a package manager (not necessarily conan).

I added instructions in the README for the new proposed workflow.
Please could you have a look at this PR and let me know if you agree on the direction?

@danpape
Copy link
Collaborator

danpape commented Feb 21, 2023

Thank you for the PR! I'm excited to check it out. I'll get back to you as soon as I can.

@matlo607 matlo607 force-pushed the fix/make-packaging-standard branch from 7a7ec32 to d53364e Compare February 21, 2023 16:52
@matlo607
Copy link
Author

matlo607 commented Feb 21, 2023

PS: I am preparing a similar PR for json-cpp. It might be better if you see how it works all together. I will probably publish the PR in a few hours.

Edit: danpape/jsonld-cpp#16

@rxgrant
Copy link

rxgrant commented Feb 22, 2023

While we're not interested in switching to Conan, we'll take a look at how to make our project dependencies more compatible with your package manager toolset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants