Skip to content

use official images #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use official images #49

wants to merge 1 commit into from

Conversation

bserem
Copy link

@bserem bserem commented Jul 9, 2024

Switch to official image

The Issue

#47

How This PR Solves The Issue

Changes the image used

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@cboyden-ucb
Copy link

I did some testing on this - the latest version of the seleniarm image that works without any changes to DDEV settings is seleniarm/standalone-chromium:4.6.0-20221104. Some changes may be needed in order to get later versions working.

@weitzman
Copy link
Collaborator

@MurzNN
Copy link
Contributor

MurzNN commented Mar 21, 2025

The problem with Drupal was that the Drupal 10.x versions used the outdated Nightwatch.js version 2.x (actually even locked to the 2.4.x version) that doesn't support the W3C protocol (which is the default for new Selenium).

And starting from the Drupal 11.1.0 release - they updated Nightwatch to 3.7 so it started to work well with the fresh Selenium: https://www.drupal.org/node/3467273

So, the outdated Selenium image doesn't work with Drupal 11.1, and we have to update it because Drupal 11.1.0 was released on 16 Dec 2024 and is well-used.

But maybe add a caveat that for the Drupal versions lower 11.1.0, we need to use the older image.

@MurzNN
Copy link
Contributor

MurzNN commented Mar 21, 2025

Drupal 11.1.x Nightwatch tests also work well even with the latest version of the Selenium image, if you set the DRUPAL_TEST_WEBDRIVER_W3C=true environment variable (or uncomment it in the [drupal_root]/core/.env file).

So, maybe set the latest in the PR too?

@rfay
Copy link
Member

rfay commented Mar 21, 2025

Rebased to run tests again.

@weitzman
Copy link
Collaborator

But maybe add a caveat that for the Drupal versions lower 11.1.0, we need to use the older image.

Sounds like a use case for a composer conflict statement

@weitzman
Copy link
Collaborator

Looks like the tests are hanging, like they have in all previous effots. i dont know why. See #42

@weitzman
Copy link
Collaborator

I am trying a bump to Drupal 11 during testing in #58. Would be nice if I could get push permission to bserem:patch-2 instead.

@star-szr
Copy link
Contributor

Just want to note that FunctionalJavascript tests also need Drupal core 11.1.x for W3C protocol support with newer selenium containers. There is an issue to back port those changes but it has stalled out for now: https://www.drupal.org/node/3421202

Legacy protocol support was dropped from Selenium in 2022 from what I could dig up: https://www.selenium.dev/blog/2022/legacy-protocol-support/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants