[ENG-4] Ensure Voting Button disappears after voting
#2688
Conversation
Deploying decent-interface with
|
| Latest commit: |
3da1bed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://be77f930.decent-interface.pages.dev |
| Branch Preview URL: | https://eng-4-button-disappears-afte.decent-interface.pages.dev |
| proposal.state === FractalProposalState.TIMELOCKED; | ||
|
|
||
| return isSnapshotProposal || isAzoriusProposal || isOtherProposalStates; | ||
| }, [snapshotProposal, canVote, hasVoted, isActiveProposal, proposal.state]); |
There was a problem hiding this comment.
Oh, probably memoizing would solve that flickering issue
There was a problem hiding this comment.
I'll memoize anyway just a good idea in general but I didn't notice any flickering. but don't doubt it
There was a problem hiding this comment.
I see couple logical issues - could you verify my assumptions regarding suitability of canVote and use only that one for isAzoriusProposal?
Also, I feel like names of variables are little misleading. I'd suggest renaming:
isSnapshotProposal->hasActionOnSnapshotProposalisAzoriusProposal->hasActionOnAzoriusProposal
| proposal.state === FractalProposalState.TIMELOCKABLE || | ||
| proposal.state === FractalProposalState.TIMELOCKED; | ||
| const showActionButton = useMemo(() => { | ||
| const isSnapshotProposal = snapshotProposal && canVote && isActiveProposal && !hasVoted; |
There was a problem hiding this comment.
On snapshot proposal you can re-do your vote - that was intentional to keep the button, cause comparing to Azorius / Multisig - you can not re-cast your vote.
Except for ERC-721 - there's a case when your voting power changed during the vote, and then you can vote once more (even for different option!) with the remaining tokens (aka tokens that weren't used during last time you've casted your vote).
There was a problem hiding this comment.
huh? lol Okay gonna need to have to write this all out on what states and what we want it to look like @nicolaus-sherrill
| proposal.state === FractalProposalState.TIMELOCKED; | ||
| const showActionButton = useMemo(() => { | ||
| const isSnapshotProposal = snapshotProposal && canVote && isActiveProposal && !hasVoted; | ||
| const isAzoriusProposal = canVote && isActiveProposal && !hasVoted; |
There was a problem hiding this comment.
So yeah - with ERC-721 it's a little more tricky
There was a problem hiding this comment.
We probably should rely just on canVote && isActiveProposal. I'd expect that canVote returns false for ERC-20 when you already voted, but true for ERC-721 if you have remaningTokensIds.length > 0.
| proposal.state === FractalProposalState.TIMELOCKED; | ||
|
|
||
| return isSnapshotProposal || isAzoriusProposal || isOtherProposalStates; | ||
| }, [snapshotProposal, canVote, hasVoted, isActiveProposal, proposal.state]); |
There was a problem hiding this comment.
Oh, probably memoizing would solve that flickering issue
|
Also I really feel like we've had a discussion that it would be preferable for button to stay but keep it disabled while voting is on... |
Closes ENG-4