feat: Modal to publish worlds to ENS names #2903
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 6332064957
💛 - Coveralls |
| }, [ensList, onRecord, analytics]) | ||
|
|
||
| useEffect(() => { | ||
| if (view === DeployToWorldView.FORM && loading && error) { |
There was a problem hiding this comment.
Should it show the error view while loading?
There was a problem hiding this comment.
This logic came from the original component.
What I understand from this is that when the user clicks on publish, loading is set to true.
Then when an error appears in the state, the useEffect picks it and changes the view to ERROR.
On the other case, if no error is provided but the current deployment is found on the store, the SUCCESS view is set.
There was a problem hiding this comment.
Answering your question: It does not show the error while loading
| className={styles.modalBodyStateActionButton} | ||
| content={t('deployment_modal.deploy_world.success.share_in_twitter')} | ||
| icon="twitter" | ||
| href={getShareInTwitterUrl()} |
There was a problem hiding this comment.
We could track the twitter sharing action if we would like to, what do you think about it?
There was a problem hiding this comment.
It might be a good idea to track it.
#2921 Created an issue in the epic to do so
| }: Props) { | ||
| const analytics = getAnalytics() | ||
|
|
||
| const [view, setView] = useState<string>('') |
There was a problem hiding this comment.
Would you mind adding tests for this component?
There was a problem hiding this comment.
It's kind of a big component. It's a pity that original one didn't have tests.
Testing the whole component will require a lot of time and might break the schedule 😢
Co-authored-by: Lautaro Petaccio <[email protected]> Signed-off-by: Fernando Zavalia <[email protected]>
fzavalia
force-pushed
the
feat/deploy-to-worlds-with-ens
branch
from
9f594ea to
becd3a1
Compare
src/modules/ens/sagas.spec.ts
Outdated
| it('should get the ens object by using the getENSBySubdomain selector', async () => { | ||
| await expectSaga(ensSaga, builderClient, ensApi) | ||
| .select(getENSBySubdomain, subdomain) | ||
| .dispatch(fetchENSWorldStatusRequest(subdomain)) |
There was a problem hiding this comment.
The main objective of the sagas tests is to check the correctness of the actions that are put (which is the objective of any saga), would you mind checking what is put?
Closes #2899
Closes #2906
Closes #2905