feat: emotes #41
feat: emotes #41
Conversation
| ## Emote search fields | ||
| searchEmoteCategory: WearableCategory | ||
| searchEmoteRarity: String # We're using String instead of WearableRarity here so we can later query this field via ()_in | ||
| searchEmoteBodyShapes: [WearableBodyShape!] |
There was a problem hiding this comment.
searchEmoteRarity and searchEmoteBodyShapes may be combined into a single searchRarity and searchBodyShapes and then get rid of the current searchWearableRarity and searchWearableBodyShapes. The thing is if we wanted to change those it would be a breaking change, so we would need to still support the old ones until migration the nft-server and potentially breaking other integrations. Also, even tho those things are repeated between wearables and emotes, they might not exist on other future type of assets (like 3D assets for the Builder) so it might be OK to let them exist only on the item types that actually use them./
There was a problem hiding this comment.
Do you want to create an issue with this?
| name: String! | ||
| description: String! | ||
| collection: String! | ||
| category: EmoteCategory! |
There was a problem hiding this comment.
The difference between the Wearable and Emote entities is the latter uses EmoteCategory instead of WearableCategory
| let wearable = buildWearableItem(item) | ||
| if (wearable != null && type == itemTypes.WEARABLE_TYPE_SHORT) { | ||
| if (type == itemTypes.WEARABLE_TYPE_SHORT) { | ||
| let wearable = buildWearableItem(item) |
There was a problem hiding this comment.
I think that if the wearable is null it will throw at line 28, 30, and for the emote at line 34, right?
There was a problem hiding this comment.
yes, i just added some checks to avoid the indexer throwing in case the metadata is malformed (1174c3f)
There was a problem hiding this comment.
Excellent!! Thanks @cazala
Do not forget to send a commit with the readme updated with the subgraph hashes 🙏
Added an
Emoteentity, and the corresponding new type of metadata