fix: publish flow (#299)

* fix: show native link instead of web * fix: remove back button on success screen * chore: linted
decentraland · Nov 11, 2024 · d1591ae · d1591ae
1 parent 67f5c45
commit d1591ae
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 16 deletions.
diff --git a/packages/renderer/src/components/Modals/PublishProject/PublishModal/component.tsx b/packages/renderer/src/components/Modals/PublishProject/PublishModal/component.tsx
@@ -2,7 +2,7 @@ import { styled } from 'decentraland-ui2';
 import { Modal as BaseModal } from 'decentraland-ui2/dist/components/Modal/Modal';
 import { type ModalProps } from 'decentraland-ui2/dist/components/Modal/Modal.types';
 
-function noop() {}
+export function onBackNoop() {}
 
 const Modal = styled(BaseModal)(props => ({
   '& > .MuiPaper-root .MuiBox-root:first-child': {
@@ -23,7 +23,7 @@ const Modal = styled(BaseModal)(props => ({
     backgroundImage: 'none',
   },
   '& [aria-label="back"]':
-    props.onBack !== noop
+    props.onBack !== onBackNoop
       ? {}
       : {
           opacity: 0,
@@ -37,7 +37,7 @@ export function PublishModal(props: React.PropsWithChildren<ModalProps>) {
     <Modal
       size="small"
       {...rest}
-      onBack={onBack || noop}
+      onBack={onBack || onBackNoop}
     >
       {props.children}
     </Modal>

diff --git a/packages/renderer/src/components/Modals/PublishProject/PublishModal/index.ts b/packages/renderer/src/components/Modals/PublishProject/PublishModal/index.ts
@@ -1 +1 @@
-export { PublishModal } from './component';
+export { PublishModal, onBackNoop } from './component';
diff --git a/packages/renderer/src/components/Modals/PublishProject/steps/Deploy/component.tsx b/packages/renderer/src/components/Modals/PublishProject/steps/Deploy/component.tsx
@@ -11,7 +11,7 @@ import { useEditor } from '/@/hooks/useEditor';
 import { useIsMounted } from '/@/hooks/useIsMounted';
 import { useAuth } from '/@/hooks/useAuth';
 import { addBase64ImagePrefix } from '/@/modules/image';
-import { PublishModal } from '../../PublishModal';
+import { PublishModal, onBackNoop } from '../../PublishModal';
 import { Button } from '../../../../Button';
 import { type Props } from '../../types';
 import type { File, Info } from './types';
@@ -160,26 +160,20 @@ export function Deploy(props: Props) {
     if (info && project) {
       if (info.isWorld) {
         if (project.worldConfiguration) {
-          return `http://decentraland.org/play/world/${project.worldConfiguration.name}`;
+          return `decentraland://?realm=${project.worldConfiguration.name}`;
         }
       } else {
-        return `http://decentraland.org/play?position=${project.scene.base}`;
+        return `decentraland://?position=${project.scene.base}`;
       }
     }
     return null;
   }, [info, project]);
 
   const handleJumpIn = useCallback(() => {
-    if (info && project) {
-      if (info.isWorld) {
-        if (project.worldConfiguration) {
-          void misc.openExternal(`decentraland://?realm=${project.worldConfiguration.name}`);
-        }
-      } else {
-        void misc.openExternal(`decentraland://?position=${project.scene.base}`);
-      }
+    if (jumpInUrl) {
+      void misc.openExternal(jumpInUrl);
     }
-  }, [info, project]);
+  }, [jumpInUrl]);
 
   return (
     <PublishModal
@@ -196,6 +190,7 @@ export function Deploy(props: Props) {
       }
       size="large"
       {...props}
+      onBack={isSuccessful ? onBackNoop : props.onBack}
     >
       <div className="Deploy">
         {showWarning ? (
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export { PublishModal } from './component';
		export { PublishModal, onBackNoop } from './component';