Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate scene #148

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix: duplicate scene #148

merged 2 commits into from
Oct 9, 2024

Conversation

cazala
Copy link
Contributor

@cazala cazala commented Oct 9, 2024

Fixes #142

This PR fixes an issue where a duplicated scene could end up with the same name/path as an existing scene. Now it uses the same logic as when creating a new scene to avoid clashing names.

@cazala cazala requested a review from cyaiox October 9, 2024 16:36
Copy link

github-actions bot commented Oct 9, 2024

Test this pull request on windows-latest

Download the correct version for your architecture:

win-x64

Copy link

github-actions bot commented Oct 9, 2024

Test this pull request on macos-latest

Download the correct version for your architecture:

mac-arm64
mac-x64

Click here if you don't know which version to download

For running this unsigned version of the app, you will need to run the xattr command on it:

  1. Extract the app from the downloaded .dmg file (double-click it)
  2. Place the extracted app anywhere you like in your file system
  3. Open a terminal on the directory where the app is
  4. Run xattr -c app-name, replacing "app-name" for the actual name of the app
  5. Double-click the app ✅

@cazala cazala merged commit cf65609 into main Oct 9, 2024
10 checks passed
@cazala cazala deleted the fix/duplicate-scene branch October 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenes: Cards duplicate after sorting them out
2 participants