feat: deploy from Creator Hub #279
Conversation
Test this pull request on windows-latestDownload the correct version for your architecture: |
Test this pull request on macos-latestDownload the correct version for your architecture:Click here if you don't know which version to downloadFor running this unsigned version of the app, you will need to run the xattr command on it:
|
packages/main/src/modules/bin.ts
Outdated
| function handleStream(stream: NodeJS.ReadableStream, type: StreamType) { | ||
| stream!.on('data', (data: Buffer) => handleData(data, matchers, type)); | ||
| } | ||
|
|
||
| handleStream(forked.stdout!); | ||
| handleStream(forked.stderr!); | ||
| handleStream(forked.stdout!, 'stdout'); | ||
| handleStream(forked.stderr!, 'stderr'); |
There was a problem hiding this comment.
I think we can remove this since it's duplicated with the event handlers at the top.
Also I think that having multiple data events for the same stream doesn't work properly since the data will be handled by one of them and the others will receive an empty flow of data. (not sure about the last one tho)
| setStep(prev || 'initial'); | ||
| setHistory(history => (history.length > 0 ? history.slice(0, -1) : [])); |
There was a problem hiding this comment.
we could probably avoid [step, setStep] by only using setHistory
we push the steps to the history array => we use the last entry on the array as the step to render. If there are no entries in the array, we always render initial. This way we avoid the double setStep, setHistory
This PR removes the use of the
linker-dappand uses a custom UI from the within the Creator Hubpublish.flow.mp4