Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: remove version from artifact (#237)" #307

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

cazala
Copy link
Contributor

@cazala cazala commented Nov 15, 2024

This reverts commit 6a425cf.

This PR makes the artifacts to include the version again in their filename. This was removed to make the download links static in this PR #237.

Now the landing fetches the download links from GitHub https://github.com/decentraland/landing/pull/451, so we can add the version back.

This could potentially fix the issues #268 and #284, according to electron-userland/electron-builder#5429 (comment)

Copy link

Test this pull request on windows-latest

Download the correct version for your architecture:

win-x64

Copy link

Test this pull request on macos-latest

Download the correct version for your architecture:

mac-arm64
mac-x64

Click here if you don't know which version to download

For running this unsigned version of the app, you will need to run the xattr command on it:

  1. Extract the app from the downloaded .dmg file (double-click it)
  2. Place the extracted app anywhere you like in your file system
  3. Open a terminal on the directory where the app is
  4. Run xattr -c app-name, replacing "app-name" for the actual name of the app
  5. Double-click the app ✅

@cazala cazala merged commit 134b5b1 into main Nov 15, 2024
10 checks passed
@cazala cazala deleted the fix/auto-updater branch November 15, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants