Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment status checks #333

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Add deployment status checks #333

merged 7 commits into from
Jan 16, 2025

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Dec 6, 2024

For testing it:

  1. Go to components/Modals/PublishProject/steps/PublishToLand/component.tsx
    • On void publishScene({ target: ... }); call, change the target to DEPLOY_URLS.DEV_CATALYST_SERVER
  2. Go to components/Modals/PublishProject/steps/Deploy/component.tsx
    • On void deploy({ address: wallet, authChain, chainId }) call, hardcode chainId: ChainId.ETHEREUM_SEPOLIA

Merge after:

decentraland/asset-bundle-registry#6

Copy link

github-actions bot commented Dec 6, 2024

Test this pull request on windows-latest

Download the correct version for your architecture:

win-x64

@nicoecheza nicoecheza force-pushed the add/publish-status branch 2 times, most recently from 91cac64 to f9bccc7 Compare December 6, 2024 15:29
Copy link

github-actions bot commented Dec 6, 2024

Test this pull request on macos-latest

Download the correct version for your architecture:

mac-arm64
mac-x64

Click here if you don't know which version to download

For running this unsigned version of the app, you will need to run the xattr command on it:

  1. Extract the app from the downloaded .dmg file (double-click it)
  2. Place the extracted app anywhere you like in your file system
  3. Open a terminal on the directory where the app is
  4. Run xattr -c app-name, replacing "app-name" for the actual name of the app
  5. Double-click the app ✅

@nicoecheza nicoecheza changed the title Add deployment status checks [DO NOT MERGE] Add deployment status checks Dec 9, 2024
@nicoecheza nicoecheza force-pushed the add/publish-status branch 2 times, most recently from 5e2551f to 5255cd8 Compare December 13, 2024 14:06
@nicoecheza nicoecheza marked this pull request as draft December 13, 2024 15:46
@Ludmilafantaniella
Copy link

Ludmilafantaniella commented Jan 10, 2025

🔴 QA:
After several hours of testing, the LOD never finished loading on either platform (Mac or Windows). As a result, I couldn’t reach the success screen with the "Jump In" button. I'm unsure how to proceed from here. Let me know if there’s anything else I should try or set up to assist with debugging this issue.

09.01.2025_18.16.38_REC.mp4

@nicoecheza nicoecheza marked this pull request as ready for review January 16, 2025 17:40
@nicoecheza nicoecheza merged commit b314905 into main Jan 16, 2025
10 checks passed
@nicoecheza nicoecheza deleted the add/publish-status branch January 16, 2025 17:40
@nicoecheza nicoecheza changed the title [DO NOT MERGE] Add deployment status checks Add deployment status checks Jan 16, 2025
nicoecheza added a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants