-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment status checks #333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this pull request on windows-latestDownload the correct version for your architecture: |
91cac64
to
f9bccc7
Compare
Test this pull request on macos-latestDownload the correct version for your architecture:Click here if you don't know which version to downloadFor running this unsigned version of the app, you will need to run the xattr command on it:
|
f9bccc7
to
ca24969
Compare
cazala
approved these changes
Dec 6, 2024
packages/renderer/src/components/Modals/PublishProject/steps/Deploy/utils.ts
Outdated
Show resolved
Hide resolved
5e2551f
to
5255cd8
Compare
5255cd8
to
0004f1d
Compare
0004f1d
to
d0e7f28
Compare
38dbcc7
to
aba153c
Compare
🔴 QA: 09.01.2025_18.16.38_REC.mp4 |
nicoecheza
added a commit
that referenced
this pull request
Jan 16, 2025
This reverts commit b314905.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing it:
components/Modals/PublishProject/steps/PublishToLand/component.tsx
void publishScene({ target: ... });
call, change the target toDEPLOY_URLS.DEV_CATALYST_SERVER
components/Modals/PublishProject/steps/Deploy/component.tsx
void deploy({ address: wallet, authChain, chainId })
call, hardcodechainId: ChainId.ETHEREUM_SEPOLIA
Merge after:
decentraland/asset-bundle-registry#6