Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update @dcl/sdk package version #431

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

cyaiox
Copy link
Collaborator

@cyaiox cyaiox commented Feb 6, 2025

This PR updates the package @dcl/sdk to version 7.7.4.

Related: decentraland/js-sdk-toolchain#1062

Testing

  • Tested dragging and dropping NFTs - works on the first attempt
  • Tested dragging and dropping Video Player - works on the first attempt
  • Tested dragging and dropping smart items - works on the first attempt
  • Verified retry mechanism works with console logging
  • Confirmed no regressions in other asset loading scenarios

Copy link

github-actions bot commented Feb 6, 2025

Test this pull request on windows-latest

Download the correct version for your architecture:

win-x64

Copy link

github-actions bot commented Feb 6, 2025

Test this pull request on macos-latest

Download the correct version for your architecture:

mac-arm64
mac-x64

Click here if you don't know which version to download

For running this unsigned version of the app, you will need to run the xattr command on it:

  1. Extract the app from the downloaded .dmg file (double-click it)
  2. Place the extracted app anywhere you like in your file system
  3. Open a terminal on the directory where the app is
  4. Run xattr -c app-name, replacing "app-name" for the actual name of the app
  5. Double-click the app ✅

@cyaiox cyaiox requested a review from nicoecheza February 6, 2025 15:58
@DafGreco DafGreco self-requested a review February 6, 2025 16:40
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows test :
✅ Tested dragging and dropping NFTs - works on the first attempt
✅Tested dragging and dropping Video Player - works on the first attempt
✅ Tested dragging and dropping smart items - works on the first attempt
✅ Verified retry mechanism works with console logging
Retrying fetch for assets/asset-packs/scifi_chest/chest_scifi.glb, attempts remaining: 2
✅Confirmed no regressions in other asset loading scenarios

image
image
image
image

Macos check:
✅ Tested dragging and dropping NFTs - works on the first attempt
✅ Tested dragging and dropping Video Player - works on the first attempt
✅ Tested dragging and dropping smart items - works on the first attempt
✅Verified retry mechanism works with console logging
Retrying fetch for assets/asset-packs/iron_fence_door/door_genesis.glb, attempts remaining: 2
✅Confirmed no regressions in other asset loading scenarios

image
image
image
image

@cyaiox cyaiox merged commit 75e1313 into main Feb 6, 2025
10 checks passed
@cyaiox cyaiox deleted the fix/update-sdk-package branch February 6, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants