Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Links #593

Merged
merged 5 commits into from
Nov 30, 2023
Merged

fix: Links #593

merged 5 commits into from
Nov 30, 2023

Conversation

LautaroPetaccio
Copy link
Contributor

This PR prefixes links if the site is built with prefixes.

Copy link
Collaborator

@braianj braianj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Comment on lines 143 to 144
console.log("Change type change", url(location.pathname, newParams))
console.log("With prefix", withPrefix("/"), withPrefix(""))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this logs?

@LautaroPetaccio LautaroPetaccio merged commit 5fd7948 into master Nov 30, 2023
2 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/links branch November 30, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants