Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query by date #664

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daxadax
Copy link

@daxadax daxadax commented Apr 1, 2024

No description provided.

Comment on lines +253 to +254
AND e.start_at >= '${date}T00:00:00.000Z
AND e.start_at < '${date}T23:59:59.000Z'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is date?

Comment on lines +52 to +59
if (query.date) {
if (isNaN(new Date(query.date))) {
//out of bound
return []
} else {
options.date = query.date
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not nest.

@@ -199,6 +199,7 @@ export type EventListOptions = {
limit?: number
offset?: number
order?: "asc" | "desc"
date?: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a more specific name for the variable like dateRange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants