-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query by date #664
base: master
Are you sure you want to change the base?
Add query by date #664
Conversation
AND e.start_at >= '${date}T00:00:00.000Z | ||
AND e.start_at < '${date}T23:59:59.000Z' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is date?
if (query.date) { | ||
if (isNaN(new Date(query.date))) { | ||
//out of bound | ||
return [] | ||
} else { | ||
options.date = query.date | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not nest.
@@ -199,6 +199,7 @@ export type EventListOptions = { | |||
limit?: number | |||
offset?: number | |||
order?: "asc" | "desc" | |||
date?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use a more specific name for the variable like dateRange
No description provided.