Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Animator component initialization #1061

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Feb 5, 2025

Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: ace1940
Status: ✅  Deploy successful!
Preview URL: https://91a92247.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-animator-component.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/animator-component/dcl-sdk-7.7.5-13242028958.commit-69476d9.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/animator-component/dcl-sdk-commands-7.7.5-13242028958.commit-69476d9.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/animator-component/@dcl/inspector/dcl-inspector-7.7.5-13242028958.commit-69476d9.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/animator-component-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/animator-component

@nicoecheza nicoecheza force-pushed the fix/animator-component branch 3 times, most recently from 39b66e6 to cdcda92 Compare February 7, 2025 15:22
@nicoecheza nicoecheza force-pushed the fix/animator-component branch from cdcda92 to ace1940 Compare February 10, 2025 13:30
@nicoecheza nicoecheza enabled auto-merge (squash) February 10, 2025 13:30
@nicoecheza nicoecheza merged commit 9986c52 into main Feb 10, 2025
8 checks passed
@nicoecheza nicoecheza deleted the fix/animator-component branch February 10, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animator component doesn't always appear
2 participants