Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make createReactBasedUiSystem public #1063

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: Make createReactBasedUiSystem public #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a85d79
feat: Make createReactBasedUiSystem public
cyaiox Feb 6, 2025
756b1ae
fix: playground-assets.api.md
cyaiox Feb 6, 2025
e96b36f
feat: Send PlayersHelpers to the initAssetPacks method
cyaiox Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@dcl/playground-assets/etc/playground-assets.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,9 @@ export function createInputSystem(engine: IEngine): IInputSystem;
// @public
export function createPointerEventsSystem(engine: IEngine, inputSystem: IInputSystem): PointerEventsSystem;

// @public (undocumented)
export function createReactBasedUiSystem(engine: IEngine, pointerSystem: PointerEventsSystem): ReactBasedUiSystem;

// @public (undocumented)
export function createTweenSystem(engine: IEngine): TweenSystem;

Expand Down
2 changes: 1 addition & 1 deletion packages/@dcl/react-ecs/src/system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface ReactBasedUiSystem {
}

/**
* @internal
* @public
*/
export function createReactBasedUiSystem(engine: IEngine, pointerSystem: PointerEventsSystem): ReactBasedUiSystem {
const renderer = createReconciler(engine, pointerSystem)
Expand Down
3 changes: 2 additions & 1 deletion packages/@dcl/sdk-commands/src/logic/bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ ${
isEditorScene &&
`
import { syncEntity } from '@dcl/sdk/network'
import players from '@dcl/sdk/players'
import { initAssetPacks, setSyncEntity } from '@dcl/asset-packs/dist/scene-entrypoint'
initAssetPacks(engine, { syncEntity })
initAssetPacks(engine, { syncEntity }, players)

// TODO: do we need to do this on runtime ?
// I think we have that information at build-time and we avoid to do evaluate this on the worker.
Expand Down
Loading