feat: introduce marketplace api fetcher and fallback mechanism#411
Open
juanmahidalgo wants to merge 3 commits intomainfrom
Open
feat: introduce marketplace api fetcher and fallback mechanism#411juanmahidalgo wants to merge 3 commits intomainfrom
juanmahidalgo wants to merge 3 commits intomainfrom
Conversation
aleortega
approved these changes
Jul 11, 2025
| getOwnedNamesOnly(address: string, first?: number, skip?: number): Promise<{ data: string[]; total: number }> | ||
| } | ||
|
|
||
| export interface MarketplaceApiResponse<T> { |
Member
There was a problem hiding this comment.
NIT:
Suggested change
| export interface MarketplaceApiResponse<T> { | |
| export type MarketplaceApiResponse<T> { |
| const result: MarketplaceApiResponse<T> = await response.json() | ||
|
|
||
| if (!result.ok) { | ||
| throw new Error(result.message || 'API request failed') |
Member
There was a problem hiding this comment.
NIT:
Suggested change
| throw new Error(result.message || 'API request failed') | |
| throw new Error(result.message || 'Marketplace API request failed') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marketplace API Integration
Key Changes
Architecture
wearablesFetcher,emotesFetcher, andnamesFetcherremain unchangedNew Components
MarketplaceApiFetcher: Primary data source for user assetsfetchAllWearablesWithFallback(): Marketplace API → TheGraph fallback for wearablesfetchAllEmotesWithFallback(): Marketplace API → TheGraph fallback for emotesfetchAllNamesWithFallback(): Marketplace API → TheGraph fallback for namesBenefits
Testing
Migration Impact