fix: add a flag to save the first loading status of the FFs #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+21
to
+26
| const [hasLoadedInitialFlags, setHasLoadedInitialFlags] = useState(false) | ||
| useEffect(() => { | ||
| if (!isLoadingFeatureFlags) { | ||
| setHasLoadedInitialFlags(true) | ||
| } | ||
| }, [isLoadingFeatureFlags]) |
There was a problem hiding this comment.
I know that it's a bit more work, but, what if we move this logic to the features flag reducer so we can eventually use it somewhere else in the future? That is, when the FF are fetched successful for the first time, we can store a flag in the feature flags state and retrieve it later with a selector.
There was a problem hiding this comment.
Will be implemented when #290 is implemented
LautaroPetaccio
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1050
Right now, the
useEffectdepends onisLoadingFeatureFlags, which toggles betweenfalseandtrueon every single request (one per minute). We just need to know the first time if loads.