fix: images url #419
Merged
fix: images url #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meelrossi
force-pushed
the
fix/images-url
branch
from
48f8226 to
f042439
Compare
Pull Request Test Coverage Report for Build 7120086083
💛 - Coveralls |
braianj
requested changes
Dec 6, 2023
src/utils/image.ts
Outdated
| import env from "decentraland-gatsby/dist/utils/env" | ||
|
|
||
| export function getImageUrl(imageUrl?: string | null) { | ||
| if (env("NEW_ROLLOUT") && imageUrl && imageUrl.startsWith("/images")) { |
There was a problem hiding this comment.
I would ask if it doesn't start with http:// or https://
Suggested change
| if (env("NEW_ROLLOUT") && imageUrl && imageUrl.startsWith("/images")) { | |
| if (env("NEW_ROLLOUT") && imageUrl && !(imageUrl.startsWith("https://") || imageUrl.startsWith("http://"))) { |
meelrossi
force-pushed
the
fix/images-url
branch
from
f042439 to
3dede4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix image src with new paths