Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: world manifest #446

Merged
merged 6 commits into from
Apr 17, 2024
Merged

feat: world manifest #446

merged 6 commits into from
Apr 17, 2024

Conversation

aleortega
Copy link
Contributor

No description provided.

@aleortega aleortega force-pushed the feat/world-manifest branch from 60d05e7 to e716690 Compare April 3, 2024 19:02
@aleortega aleortega force-pushed the feat/world-manifest branch from e716690 to 64aee26 Compare April 3, 2024 19:05
braianj
braianj requested changes Apr 3, 2024
View reviewed changes
src/entities/CheckScenes/task/taskRunnerSqs.ts Outdated Show resolved Hide resolved
src/entities/CheckScenes/RoadCoordinates.json Outdated Show resolved Hide resolved
src/entities/CheckScenes/task/taskRunnerSqs.ts Outdated Show resolved Hide resolved
src/entities/CheckScenes/utils.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8725230493

Details

  • 25 of 95 (26.32%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 94.266%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/entities/CheckScenes/utils.ts 25 95 26.32%
Files with Coverage Reduction New Missed Lines %
src/utils/rating/contentRating.ts 8 82.8%
Totals Coverage Status
Change from base Build 8468293608: -0.5%
Covered Lines: 13890
Relevant Lines: 14605
💛 - Coveralls

braianj
braianj approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@braianj braianj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

src/entities/CheckScenes/task/taskRunnerSqs.ts Outdated Show resolved Hide resolved
@aleortega aleortega force-pushed the feat/world-manifest branch from 9e99b06 to ae4ff99 Compare April 17, 2024 16:12
@aleortega aleortega marked this pull request as ready for review April 17, 2024 16:16
@aleortega aleortega merged commit 7853c9d into master Apr 17, 2024
2 checks passed
@aleortega aleortega deleted the feat/world-manifest branch April 17, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braianj braianj braianj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleortega @braianj