Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: manifest upload to avoid using signed urls #453

Merged
merged 1 commit into from
Apr 19, 2024
Merged

refactor: manifest upload to avoid using signed urls #453

merged 1 commit into from
Apr 19, 2024

Conversation

aleortega
Copy link
Contributor

No description provided.

@aleortega aleortega marked this pull request as ready for review April 18, 2024 20:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8755090016

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 94.313%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/entities/CheckScenes/utils.ts 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
src/entities/Place/utils.ts 2 80.16%
Totals Coverage Status
Change from base Build 8743828857: 0.1%
Covered Lines: 13884
Relevant Lines: 14589
💛 - Coveralls

@aleortega aleortega force-pushed the refactor/how-manifest-is-uploaded branch from 1fcd4e6 to 5294b6a Compare April 19, 2024 14:19
braianj
braianj approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@braianj braianj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@aleortega aleortega merged commit d5455ac into master Apr 19, 2024
2 checks passed
@aleortega aleortega deleted the refactor/how-manifest-is-uploaded branch April 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braianj braianj braianj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleortega @braianj