Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Order by created_at option #557

Merged
merged 4 commits into from
Nov 4, 2024
Merged

fix: Order by created_at option #557

merged 4 commits into from
Nov 4, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Nov 4, 2024

This PR fixes the order Places records with the created_at option.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11667993892

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 94.263%
Files with Coverage Reduction New Missed Lines %
src/utils/position/toCanonicalPosition.ts 2 80.95%
Totals Coverage Status
Change from base Build 11665537494: -0.03%
Covered Lines: 13903
Relevant Lines: 14613
💛 - Coveralls

@cyaiox cyaiox merged commit a8c43cd into master Nov 4, 2024
2 checks passed
@cyaiox cyaiox deleted the fix/sort-by-logic branch November 4, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braianj braianj braianj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyaiox @braianj