Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add get all places endpoint #560

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Nov 8, 2024

This PR introduces a new endpoint that combines Genesis City and Worlds scenes data into a single, unified response.

Closes: #553

Copy link

github-actions bot commented Nov 8, 2024

Pull Request Test Coverage Report for Build 11918649209

Details

  • 997 of 1044 (95.5%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 94.143%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/entities/Map/utils.ts 53 54 98.15%
src/entities/Map/routes/getAllPlacesMostActiveList.ts 112 114 98.25%
src/entities/World/utils.ts 11 24 45.83%
src/entities/Place/model.ts 159 190 83.68%
Totals Coverage Status
Change from base Build 11824512700: -0.09%
Covered Lines: 15535
Relevant Lines: 16308

💛 - Coveralls

Copy link
Collaborator

@braianj braianj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work! 🎉

export const fetchWorldsLiveDataAndUpdateCache = async (): Promise<void> => {
try {
const liveFetch = await fetch(
"https://worlds-content-server.decentraland.org/live-data"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about adding this to config files and using env()

Verified

This commit was signed with the committer’s verified signature.
cyaiox Gabriel Díaz

Verified

This commit was signed with the committer’s verified signature.
cyaiox Gabriel Díaz

Verified

This commit was signed with the committer’s verified signature.
cyaiox Gabriel Díaz

Verified

This commit was signed with the committer’s verified signature.
cyaiox Gabriel Díaz

Verified

This commit was signed with the committer’s verified signature.
cyaiox Gabriel Díaz
@cyaiox cyaiox force-pushed the feat/add-getAllPlaces-endpoint branch from b93429d to e165f73 Compare November 19, 2024 17:18

Verified

This commit was signed with the committer’s verified signature.
cyaiox Gabriel Díaz
@cyaiox cyaiox force-pushed the feat/add-getAllPlaces-endpoint branch from e165f73 to 9db1cae Compare November 19, 2024 17:40
@cyaiox cyaiox merged commit 0533ea4 into master Nov 19, 2024
2 checks passed
@cyaiox cyaiox deleted the feat/add-getAllPlaces-endpoint branch November 19, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new endpoint to merge Places and Worlds data
2 participants