fix: Most active Places Sort by and hot scenes memory leak #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12998362884Details
💛 - Coveralls |
braianj
approved these changes
Jan 28, 2025
| @@ -60,7 +60,7 @@ export const getPlaceMostActiveList = Router.memo( | |||
| only_highlighted: !!bool(query.only_highlighted), | |||
| positions: query.positions, | |||
| hotScenesPositions: hotScenesPositions, | |||
| order_by: PlaceListOrderBy.MOST_ACTIVE, | |||
| order_by: PlaceListOrderBy.UPDATED_AT, | |||
There was a problem hiding this comment.
Are you sure that un the getPlaceMostActiveList we should use UPDATED_AT as default
There was a problem hiding this comment.
this change is because doesn't exist column most_active in the table, so this will sort in SQL using updated_at, then we are applying the sort by most_active to the results
| @@ -1,47 +1,58 @@ | |||
| import Time from "decentraland-gatsby/dist/utils/date/Time" | |||
| import env from "decentraland-gatsby/dist/utils/env" | |||
| import fetch, { RequestInit } from "node-fetch" | |||
| import deepmerge from "deepmerge" | |||
There was a problem hiding this comment.
what do you think about using radash that's in decentraland gatsby?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the sort by for most active places and merges the data from the legacy realms and the ea archipelago.