Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send binary message to specific address #222

Merged
merged 6 commits into from
Jan 21, 2025
Merged

send binary message to specific address #222

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75453af
send binary message to specific address
gonpombo8 Sep 30, 2024
796129a
update naming & update branch
gonpombo8 Jan 9, 2025
a84e5a6
update address to be an array
gonpombo8 Jan 13, 2025
54b2457
use only peerData
gonpombo8 Jan 15, 2025
3f3b695
Merge branch 'main' into feat/send-comms-to-peer
gonpombo8 Jan 17, 2025
51104b6
Merge branch 'main' into feat/send-comms-to-peer
gonpombo8 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions proto/decentraland/kernel/apis/communications_controller.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@ message RealSendRequest {
message RealSendResponse {}

message SendBinaryRequest {
repeated bytes data = 1; // @deprecated old broadcasted messages. Use peerData with an empty array for broadcasting.
repeated PeerMessageData peer_data = 2; // peer-to-peer messages
}

message PeerMessageData {
repeated bytes data = 1;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ok that this is an array of data ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be bytes data = 1, not an array of bytes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if you reach the size limit for a single message and you need to send it in chunks

repeated string address = 2; // if address is empty, its a broadcast message
}

message SendBinaryResponse {
Expand Down
Loading