Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reorganize social service protos, and remove duplication #241

Merged
merged 2 commits into from
Jan 21, 2025
Merged

refactor: reorganize social service protos, and remove duplication #241

merged 2 commits into from
Jan 21, 2025

Conversation

kuruk-mm
Copy link
Member

  • decentraland/social/friendships/friendships.proto and decentraland/social_service/v1/social_service_v1.proto were identical
  • remove unused decentraland/social_service/v2/social_service_v2.proto
  • rename decentraland/social_service/v3/social_service_v3.proto to v2
  • remove unused decentraland/social_service_v2/social_service.proto

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Test this pull request

  • The @dcl/protocol package can be tested in scenes by running 
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-12876819223.commit-5022ba6.tgz"

@kuruk-mm kuruk-mm merged commit cbbf46c into main Jan 21, 2025
2 of 3 checks passed
@kuruk-mm kuruk-mm deleted the refactor/social-service branch January 21, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinszuchet kevinszuchet kevinszuchet approved these changes

Assignees
No one assigned
Labels
breaks compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuruk-mm @kevinszuchet