Added social emote outcome index #309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the outcome is > -1 it means the avatar started an animation that uses the configuration in one of the outcomes defined in the emote's metadata.
Test this pull request on NPM or Yarn
|
This reverts commit 44e70ba.
When the outcome is > -1 it means the avatar started an animation that uses the configuration in one of the outcomes defined in the emote's metadata.
kuruk-mm
reviewed
Sep 26, 2025
| uint32 incremental_id = 1; | ||
| string urn = 2; | ||
| float timestamp = 3; | ||
| int32 social_emote_outcome = 4; // -1 means it does not use an outcome animation |
There was a problem hiding this comment.
You can use optional instead of the -1 case to be clearer.
Suggested change
| int32 social_emote_outcome = 4; // -1 means it does not use an outcome animation | |
| optional int32 social_emote_outcome = 4; // no-value means it does not use an outcome animation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to develop this shape: https://www.notion.so/decentraland/Social-Emotes-22d5f41146a5809dbe8ff69a9682f353
When the outcome is > -1 it means the avatar started an animation that uses the configuration in one of the outcomes defined in the emote's metadata.