Feat: add map pins layer #1306
Merged
Feat: add map pins layer #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davidejensen <[email protected]>
Signed-off-by: davidejensen <[email protected]>
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
davidejensen
added
the
no QA needed
fcolarich
reviewed
Jul 5, 2024
fcolarich
reviewed
Jul 5, 2024
Explorer/Assets/DCL/MapRenderer/ConsumerUtils/MapRenderImage.cs
Outdated
Show resolved
Hide resolved
fcolarich
reviewed
Jul 5, 2024
Explorer/Assets/DCL/MapRenderer/MapCameraController/MapCameraInteractivityController.cs
Outdated
Show resolved
Hide resolved
fcolarich
reviewed
Jul 5, 2024
fcolarich
requested changes
Jul 5, 2024
mikhail-dcl
requested changes
Jul 9, 2024
Explorer/Assets/DCL/MapPins/Components/MapPinHolderComponent.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/MapRenderer/MapLayers/Pins/PinMarkerController.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/MapRenderer/MapLayers/Pins/PinMarkerController.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/MapRenderer/MapLayers/Pins/PinMarkerController.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/MapRenderer/MapLayers/Pins/PinMarkerController.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/MapRenderer/MapLayers/Pins/PinMarkerObject.cs
Outdated
Show resolved
Hide resolved
mikhail-dcl
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR adds support to create map pins on the map based on the new experimental SDK component defined here: decentraland/protocol#205
There is also an SDK experimental branch that allows this creation here: decentraland/js-sdk-toolchain#974
...
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md