chore: move alpha_texture from PBRMaterial to UnlitMaterial #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Rebuilt protocol Material class
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
This was referenced Oct 17, 2024
…al system to support the new alphaTexture property of the BaseMaterial component. Removed and ignored alpha texture request and assign for PBR material
github-actions
bot
requested review from
dalkia,
lorux0 and
Ludmilafantaniella
AlejandroAlvarezMelucciDCL
requested review from
a team
and removed request for
dalkia,
lorux0 and
Ludmilafantaniella
pravusjif
approved these changes
Oct 18, 2024
Ludmilafantaniella
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
🟢 Chore verified on Mac and Window. Both pillars have the corresponding video materials (Old one is using PBR Material, New one is using BasicMaterial (Unlit). Approved by QA.
2482.mp4
Smoke test was performed covering:
- Scenes with video streaming like Casa Roustan
- Backpack (emotes and wereables)
- Metadynelabs world
…re/move-alphaTexture-from-PBRMaterial-to-UnlitMaterial
GBirch33
approved these changes
Oct 21, 2024
dalkia
approved these changes
Oct 21, 2024
pravusjif
deleted the
chore/move-alphaTexture-from-PBRMaterial-to-UnlitMaterial
branch
m3taphysics
added a commit
that referenced
this pull request
Oct 22, 2024
* refactor: Use the bucket public url (#2486) * fix: Use the bucket public url * fix: Branch name reference * refactor: Use a defined github var * add support for global sounds (#2495) * fix: Scene Parallax Dynamic Branching fix (#2459) * Scene Parallax Dynamic Branching fix * Add the Mac shaders * chore: 'Cannot connect to destination hsot' mac mitigation (#2425) * Hacky force unload * More force unloading * private force unloading * Remove dependency unload * Remove Resources.Unload in aggresive strategy. Not useful * Fix cacheable url * Fixed dependency unloading * Fix main asset unload * Fix test * Fixed more tests * Fixed more tests * more mote tests * Revert priority * null check in GatherGLTFAssetsSystem.cs * Revert "Remove Resources.Unload in aggresive strategy. Not useful" This reverts commit 383e5fe. * refactored unload strategy * Test coverage * Textures leaked when leaving and entering Genesis plaza (#2129) (#2484) * fix: Unable to recover initial memory state in GP (#2129) Now cached texture intentions are compared using the texture file hash instead of the URL that was used to download it. Now it does not matter which content server is the candidate to get the texture from, if the instance was previously stored, it will reuse it when entering Genesis plaza. * Cleaning code, step 1 Created a separated method to get the file hash. * Cleaning step 2 * Cleaning step 3 * Null check (#2501) * replaced data type in query: (#2504) * chore: sync main to dev (#2507) Co-authored-by: Ashley Canning <[email protected]> * added missing IFinalizeWorldSystem implementation in system (#2506) * Fix: UnityWebRequest exception request aborted (#2498) ## What does this PR change? Add dispose for the request and exception not thrown after that ## How to test the changes? not needed * Fix: Handle RunConnectCycleStepAsync safer (#2478) * Handle RunConnectCycleStepAsync safer * Add logs in case of failed delivery * More logs * Preserve the previous connection if the players returns to the scene * Fix connectedScene assigning * Restore ConnectiveRoom.Fake * fix: bind connection status panel visibility to debug command (#2441) * fix: weekly release page (#2513) Signed-off-by: Juan Ignacio Molteni <[email protected]> * chore: move alpha_texture from PBRMaterial to UnlitMaterial (#2482) Implemented support for alpha texture on SDK unlit material component * fix: Textures in the panels at Genesis plaza main spawn area are not appearing (#2514) Those panels use textures downloaded from arbitrary URLs and not from the content servers, which means they will not have a file hash available. File hashes were being used as "key" in the texture cache (GetTextureIntention are the actual key, but they compare using a hash partially formed by the file hash). Now either the hash or the source URL is used to form the key/hash, depending on whether the file hash is available. * bumped cache version for landscape (#2515) ## What does this PR change? see title ## How to test the changes? check if [#2190](#2190) is fixed --------- Signed-off-by: Juan Ignacio Molteni <[email protected]> Co-authored-by: Gabriel Díaz <[email protected]> Co-authored-by: Nicolas Lorusso <[email protected]> Co-authored-by: Geoff Birch <[email protected]> Co-authored-by: Juan Ignacio Molteni <[email protected]> Co-authored-by: Alex Villalba <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Pravus <[email protected]> Co-authored-by: Vitaly Popuzin <[email protected]> Co-authored-by: Mikhail Agapov <[email protected]> Co-authored-by: lorenzo-ranciaffi <[email protected]> Co-authored-by: Alejandro Alvarez Melucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Due to performance reasons the Explorer Alpha won't be supporting alpha texture on SDK PBR Materials any time soon.
However, the shader used for Unlit Material supports alpha texture.
WHAT
Addresses the E@ part of issue #240
Related PRs:
Protocol: decentraland/protocol#223
SDK: decentraland/js-sdk-toolchain#1019
QA TEST INSTRUCTIONS
/goto AleAlvarez