Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Member list feature implementation #3372

Merged
merged 8 commits into from
Feb 15, 2025

Conversation

QThund
Copy link
Contributor

@QThund QThund commented Feb 15, 2025

Pull Request Description

What does this PR change?

Implementation of the Member list

Test Instructions

QThund and others added 7 commits February 13, 2025 00:46
Profile data is unreliable, a mechanism has to be implemented in order to wait for the data to be present in the cache.
Added prefabs of Friends branch to reuse the profile info item in the list.
Added the Profile cache to the view dependencies.
Changed the font size of the Nearby text.
Now the text in the Memberlist button is 0 instead of 200.
Reduced the border of the soft mask in the scrollview.
Now it shows the amount of members in a reliable way.
Now it updates when jumping to another world.
Now when Enter is pressed, the member list closes and the input box gains the focus.
Now new chat messages are correctly formatted when the member list is closed.
Many visual UI fixes. Now the member count button adjusts automatically to its content.
Copy link
Contributor

badge

New build in progress, come back later!

@QThund QThund self-assigned this Feb 15, 2025
Copy link
Contributor

@fcolarich fcolarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, but I dont see any glaring issue. We will probably improve the fetching and updating in the next shape (or during next week :))

- Now the chat controller uses the cached color of the profile.
- Removed commented test code.
- Fixed: The input box was hiding when closing the chat window while the Member list panel was visible.
@QThund QThund merged commit 8698cd3 into feat/chat/chat_improvements_main Feb 15, 2025
5 checks passed
@QThund QThund deleted the feat/chat/member-list branch February 15, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants