-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Member list feature implementation #3372
Merged
QThund
merged 8 commits into
feat/chat/chat_improvements_main
from
feat/chat/member-list
Feb 15, 2025
Merged
Chat Member list feature implementation #3372
QThund
merged 8 commits into
feat/chat/chat_improvements_main
from
feat/chat/member-list
Feb 15, 2025
+6,077
−427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profile data is unreliable, a mechanism has to be implemented in order to wait for the data to be present in the cache. Added prefabs of Friends branch to reuse the profile info item in the list. Added the Profile cache to the view dependencies.
Changed the font size of the Nearby text. Now the text in the Memberlist button is 0 instead of 200. Reduced the border of the soft mask in the scrollview.
Now it shows the amount of members in a reliable way. Now it updates when jumping to another world. Now when Enter is pressed, the member list closes and the input box gains the focus. Now new chat messages are correctly formatted when the member list is closed. Many visual UI fixes. Now the member count button adjusts automatically to its content.
fcolarich
reviewed
Feb 15, 2025
fcolarich
reviewed
Feb 15, 2025
fcolarich
reviewed
Feb 15, 2025
fcolarich
reviewed
Feb 15, 2025
fcolarich
approved these changes
Feb 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, but I dont see any glaring issue. We will probably improve the fetching and updating in the next shape (or during next week :))
- Now the chat controller uses the cached color of the profile. - Removed commented test code. - Fixed: The input box was hiding when closing the chat window while the Member list panel was visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
Implementation of the Member list
Test Instructions