LMA Intercept RHI #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 76.64% 77.45% +0.80%
==========================================
Files 12 13 +1
Lines 1734 1805 +71
==========================================
+ Hits 1329 1398 +69
- Misses 405 407 +2 ☔ View full report in Codecov by Sentry. |
|
Just visited in person with @wx4stg with a few clarification comments on use, as in the most recent commit. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs coordinate transformations for LMA plotting source locations along a radar RHI (range from radar, distance from plane of scan, height above ground)
This is mostly (~90%) a reimplementation of Souza & Bruning 2021
This is a draft (for now), I need to add tests, better docs, and hopefully remove the dependency on py-ART (which would allow for manually specifying an azimuth, time, rangemax, etc. Useful if you have a volume ppi scan and want to make psuedo-RHIs, as well as other 'creative' uses, possibly involving aircraft radars)