Skip to content

Fix: Add the correct RT-TDDFT electric field force acting on ions #5918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

AsTonyshment
Copy link
Collaborator

Linked Issue

Fix #5894.

@mohanchen mohanchen added Refactor Refactor ABACUS codes Bugs Bugs that only solvable with sufficient knowledge of DFT labels Feb 22, 2025
@mohanchen mohanchen merged commit b774535 into deepmodeling:develop Feb 22, 2025
14 checks passed
@AsTonyshment AsTonyshment deleted the fix_TDDFT_force branch February 22, 2025 10:04
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
…epmodeling#5918)

* Fix: Add the correct RT-TDDFT electric field force acting on ions

* Fix a CI/CD test issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: It seems that the electric field force in RT-TDDFT is not applied at all, and the wrong function was called as well
3 participants