Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Converters #6546

Closed
anakin87 opened this issue Dec 14, 2023 · 1 comment
Closed

Standardize Converters #6546

anakin87 opened this issue Dec 14, 2023 · 1 comment
Assignees
@anakin87
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint

Comments

@anakin87
Copy link
Member

Currently, (file) Converters are not very uniform.
They accept different input parameters and there is some duplication...

Discussing with Silvano, we agreed on the following strategy:

  • make Converters accept sources (List[Union[str, Path, ByteStream]) in the run method
  • make Converters always work internally with ByteStream objects for conversion
  • make all Converters accept meta in the run method, so that users can provide their own metadata.
@anakin87 anakin87 self-assigned this Dec 14, 2023
@anakin87 anakin87 added P1 High priority, add to the next sprint 2.x Related to Haystack v2.0 labels Dec 14, 2023
This was referenced Dec 14, 2023
Closed
Merged
Merged
Merged
@anakin87
Copy link
Member Author

Fixed in #6540, #6554 and #6556!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anakin87 anakin87

Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anakin87