feat: Converters - allow passing meta in the run method
#6554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
dfokina and
masci
and removed request for
a team
github-actions
bot
added
topic:tests
2.x
anakin87
changed the base branch from
main
to
converters-standardize-sources
anakin87
commented
Dec 14, 2023
| @@ -56,8 +56,8 @@ def __init__(self, endpoint: str, api_key: Optional[str] = None, model_id: str = | |||
| self.endpoint = endpoint | |||
| self.model_id = model_id | |||
|
|
|||
| @component.output_types(documents=List[Document], azure=List[Dict]) | |||
| def run(self, sources: List[Union[str, Path, ByteStream]]): | |||
| @component.output_types(documents=List[Document], raw_azure_response=List[Dict]) | |||
There was a problem hiding this comment.
this is not related to this PR but the declaration did not match with the return value of the run method, so I fixed it.
Co-authored-by: Massimiliano Pippi <[email protected]>
anakin87
added a commit
that referenced
this pull request
Dec 15, 2023
* standardize converters inputs: first draft * fix precommit * fix precommit 2 * fix precommit 3 * add default for optional param * rm leftover * install boilerpy in linting workflow * add boilerpy3 to the core dependencies * add reno * remove boilerpy3 installation from test workflow * fix pylint: import order and unused import * fix import order * add release note * better Tika docstring * rm boilerpy from linting * leftover * md link brackets * feat: Converters - allow passing `meta` in the `run` method (#6554) * first impl for html * progressing on other components * fix test * add tests - run with meta * release note * reintroduce patches wrongly deleted * add patch in test * fix tika test * Update haystack/components/converters/azure.py Co-authored-by: Massimiliano Pippi <[email protected]> --------- Co-authored-by: Massimiliano Pippi <[email protected]> * Update releasenotes/notes/converters-standardize-inputs-ed2ba9c97b762974.yaml Co-authored-by: Silvano Cerza <[email protected]> * simplify test --------- Co-authored-by: Massimiliano Pippi <[email protected]> Co-authored-by: Julian Risch <[email protected]> Co-authored-by: Daria Fokina <[email protected]> Co-authored-by: Silvano Cerza <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
please do not merge the current one before the base has been merged
Proposed Changes:
metain therunmethod, so that users can provide their own metadata.The length of this list should match the number of
sources.How did you test it?
CI, new unit tests
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.