Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable linting for the core package #7677

Merged
merged 2 commits into from
May 9, 2024
Merged

re-enable linting for the core package #7677

merged 2 commits into from
May 9, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented May 9, 2024 •
edited
Loading

Related Issues

  • fixes n/a

Proposed Changes:

Remove leftover from Canals migration

How did you test it?

Notes for the reviewer

Checklist

@masci masci marked this pull request as ready for review May 9, 2024 12:27
@masci masci requested a review from a team as a code owner May 9, 2024 12:27
@masci masci requested review from shadeMe and removed request for a team May 9, 2024 12:27
@github-actions github-actions bot added topic:core type:documentation Improvements on the docs labels May 9, 2024
@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label May 9, 2024
@masci masci enabled auto-merge (squash) May 9, 2024 12:32
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9017301180

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 90.406%
Files with Coverage Reduction New Missed Lines %
core/pipeline/descriptions.py 3 54.55%
Totals Coverage Status
Change from base Build 9015366763: 0.0%
Covered Lines: 6521
Relevant Lines: 7213
💛 - Coveralls

@masci masci merged commit 02b8a07 into main May 9, 2024
24 of 25 checks passed
@masci masci deleted the masci-patch-1 branch May 9, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@shadeMe shadeMe Awaiting requested review from shadeMe shadeMe is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:CI topic:core type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @coveralls @silvanocerza