chore: Simplify Pipeline.run method by moving code to the base class
#7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
requested review from
julian-risch
and removed request for
a team and
julian-risch
github-actions
bot
added
topic:tests
topic:core
type:documentation
masci
commented
May 10, 2024
| # TODO: Support also this format: | ||
| # data = { | ||
| # "input1": 1, "input2": 2, | ||
| # } |
There was a problem hiding this comment.
This comment was outdated
masci
commented
May 10, 2024
| # This implementation of run supports only the first format, but the second format is actually | ||
| # never received by this method. It's handled by the `run()` method of the `Pipeline` class | ||
| # defined in `haystack/pipeline.py`. | ||
| # As of now we're ok with this, but we'll need to merge those two classes at some point. |
There was a problem hiding this comment.
This comment was outdated
masci
commented
May 10, 2024
| pipe.connect("greet", "adder") | ||
| pipe._init_graph() | ||
| for node in pipe.graph.nodes: | ||
| assert pipe.graph.nodes[node]["visits"] == 0 |
There was a problem hiding this comment.
Should I do the same for the newly added private methods?
There was a problem hiding this comment.
Yeah, that would be cool.
masci
added
the
ignore-for-release-notes
Pull Request Test Coverage Report for Build 9086069754Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
silvanocerza
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
This PR has the only purpose to clean up the logic of the
runmethod by moving code around, no functional changes.It should also make the code more testable, but knowing we have #7611 pending, I'm not touching them.
There's more code to move, but I want to keep the diff small to speed up the review process.
How did you test it?
Existing tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.