feat: update L2 genesis specs #20
Open
+95
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xOneTony
reviewed
Feb 13, 2025
| | `L1_ERC_721_BRIDGE_ADDRESS` | `uint8(5)` | Sets the `L1ERC721Bridge` address | | ||
| | `L1_STANDARD_BRIDGE_ADDRESS` | `uint8(6)` | Sets the `L1StandardBridge` address | | ||
| | `REMOTE_CHAIN_ID` | `uint8(7)` | Sets the chain id of the base chain | | ||
| | Name | Value | Description | |
There was a problem hiding this comment.
Missing ADD_DEPENDENCY and REMOVE_DEPENDENCY
| | `GAS_LIMIT` | `uint8(2)` | `abi.encode(uint64 _gasLimit)` | Modifies the L2 gas limit | | ||
| | `UNSAFE_BLOCK_SIGNER` | `uint8(3)` | `abi.encode(address)` | Modifies the account that is authorized to progress the unsafe chain | | ||
| | `EIP_1559_PARAMS` | `uint8(4)` | `uint256(uint64(uint32(_denominator))) << 32 \| uint64(uint32(_elasticity))` | Modifies the EIP-1559 denominator and elasticity | | ||
| | Name | Value | Definition | Usage | |
There was a problem hiding this comment.
Missing FEE_VAULT_ADMIN which is added here defi-wonderland/optimism#274
There was a problem hiding this comment.
There will be a need for addition on the Initialization paragraph aswell probably
There was a problem hiding this comment.
Regarding the OptimismPortal2 on the upgrade the function signature is missing 1 param, check defi-wonderland/optimism#273
There was a problem hiding this comment.
Also on the same note, it mentions
to is Predeploys.ProxyAdmin
Should be changed to Predeploys.L2_PROXY_ADMIN
| | `L1_ERC_721_BRIDGE_ADDRESS` | `bytes32(uint256(keccak256("opstack.l1erc721bridgeaddress")) - 1)` | `abi.encode(address(L1ERC721BridgeProxy))` | | ||
| | `L1_STANDARD_BRIDGE_ADDRESS` | `bytes32(uint256(keccak256("opstack.l1standardbridgeaddress")) - 1)` | `abi.encode(address(L1StandardBridgeProxy))` | | ||
| | `REMOTE_CHAIN_ID` | `bytes32(uint256(keccak256("opstack.remotechainid")) - 1)` | Chain ID of the remote chain | | ||
| | Name | Value | Definition | |
There was a problem hiding this comment.
I dont quite follow where these constants come from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-647