Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

longevity stopping after particular duration fix #145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gilltaran
Copy link
Contributor

@gilltaran gilltaran commented Feb 7, 2025

Description

Longevity was not taking the -d flag . If we run it for 1 day it was keep on running even beyond that until we manually stopping it.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1720

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

I have tried running longevity for iterations as well as for duration it is running fine . Full results has been attached in Jira defects

[2025-02-07 04:43:13] INFO Namespace prov-test-7bcc735e was deleted in 22.048347971s
[2025-02-07 04:43:15] INFO SUCCESS: ProvisioningSuite in 40.033663439s
[2025-02-07 04:43:15] INFO Trying to connect to cluster...
[2025-02-07 04:43:15] INFO Created new KubeClient
[2025-02-07 04:43:15] INFO Stopping execution as duration has elapsed.
[2025-02-07 04:43:15] INFO Started generating reports...
Collecting metrics
3 / 3 [-----------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% ? p/s[2025-02-07 04:43:15] INFO Started generating reports...
Collecting metrics
3 / 3 [--------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant