Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell updates #124

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Shell updates #124

wants to merge 3 commits into from

Conversation

harishp8889
Copy link
Contributor

@harishp8889 harishp8889 commented Feb 5, 2025 •
edited
Loading

Description

  1. Updated shell type as bash to use for image push actions to avoid misinterpretation of certain logic specific to bash
  2. Updated action to attach built binaries in previous steps.

Issues

List the issues impacted by this PR:

Issue ID
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@harishp8889 harishp8889 self-assigned this Feb 5, 2025
@harishp8889 harishp8889 changed the title Binary attach for release Shell updates Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell will be requested when the pull request is marked ready for review AronAtDell is a code owner

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell will be requested when the pull request is marked ready for review ChristianAtDell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork will be requested when the pull request is marked ready for review donatwork is a code owner

@meggm meggm Awaiting requested review from meggm meggm will be requested when the pull request is marked ready for review meggm is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher will be requested when the pull request is marked ready for review gallacher is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 will be requested when the pull request is marked ready for review hoppea2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell will be requested when the pull request is marked ready for review mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 will be requested when the pull request is marked ready for review prablr79 is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama will be requested when the pull request is marked ready for review sharmilarama is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro will be requested when the pull request is marked ready for review shaynafinocchiaro is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@harishp8889 harishp8889

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@harishp8889