Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Network Rule Datasource #112

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Implement Network Rule Datasource #112

merged 1 commit into from
Jan 16, 2024

Conversation

NavisJ
Copy link
Contributor

@NavisJ NavisJ commented Jan 11, 2024

Description

Implement network rule data source

ISSUE TYPE

  • Feature Pull Request
RESOURCE OR DATASOURCE NAME

Network rule

OUTPUT

image
image

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@NavisJ
Copy link
Contributor Author

NavisJ commented Jan 11, 2024

run e2e test

@NavisJ NavisJ force-pushed the network-rule-datasource branch from 782333b to 7c67b39 Compare January 15, 2024 04:45
@NavisJ
Copy link
Contributor Author

NavisJ commented Jan 15, 2024

run e2e test

1 similar comment
@forrestxia
Copy link
Collaborator

run e2e test

@NavisJ NavisJ merged commit 1734c43 into main Jan 16, 2024
7 checks passed
@NavisJ NavisJ deleted the network-rule-datasource branch January 16, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants