Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update zone name #99

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Support update zone name #99

merged 1 commit into from
Nov 21, 2023

Conversation

P-Cao
Copy link
Contributor

@P-Cao P-Cao commented Nov 20, 2023

Though quota and smb share does not support zone modification, zone name could be renamed
Now fix bug during renaming access zone

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE OR DATASOURCE NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

Though quota and smb share does not support zone modification, zone name
could be renamed
Now fix bug during renaming access zone
@P-Cao
Copy link
Contributor Author

P-Cao commented Nov 20, 2023

run e2e test

@P-Cao P-Cao marked this pull request as ready for review November 21, 2023 02:07
Copy link
Contributor

@baoy1 baoy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the zone in nfs export, Cannot be changed once set.
What happens for nfs export if user updated zone in abridge case?

@P-Cao P-Cao merged commit ce10636 into main Nov 21, 2023
@P-Cao P-Cao deleted the bugfix-support-zone-name-update branch November 21, 2023 02:49
@tanh17
Copy link
Contributor

tanh17 commented Nov 21, 2023

For the zone in nfs export, Cannot be changed once set. What happens for nfs export if user updated zone in abridge case?

Error updating nfs export when changing zone's name. The error message is "Do not change access zone once set".

@baoy1
Copy link
Contributor

baoy1 commented Nov 21, 2023

For the zone in nfs export, Cannot be changed once set. What happens for nfs export if user updated zone in abridge case?

Error updating nfs export when changing zone's name. The error message is "Do not change access zone once set".

There are two scenarios, 1, update zone in nfs export payload, that is not permitted based on the code design. We show "Do not change access zone once set". 2. rename zone resource in abridge scenario, will terraform perform update on nfs export, then show "Do not change access zone once set"?
Based on UI, after renaming zone, nfs export is still visible under the zone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants