Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/27/native exe #32

Merged
merged 7 commits into from
Mar 9, 2019
Merged

Feature/27/native exe #32

merged 7 commits into from
Mar 9, 2019

Conversation

hariharansrc
Copy link
Member

Move away from akka http #27

@hariharansrc hariharansrc requested a review from bhermann January 24, 2019 10:58
@ghost ghost assigned hariharansrc Jan 24, 2019
@ghost ghost added the review label Jan 24, 2019
@bhermann
Copy link
Member

Cool work! How fast is it?

@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #32 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #32   +/-   ##
=====================================
  Coverage        0%    0%           
=====================================
  Files            9    10    +1     
  Lines          200   199    -1     
  Branches         8    10    +2     
=====================================
+ Misses         200   199    -1
Impacted Files Coverage Δ
...b/cs/swt/delphi/cli/commands/RetrieveCommand.scala 0% <0%> (ø) ⬆️
...upb/cs/swt/delphi/cli/commands/SearchCommand.scala 0% <0%> (ø) ⬆️
...ain/scala/de/upb/cs/swt/delphi/cli/DelphiCLI.scala 0% <0%> (ø) ⬆️
...la/de/upb/cs/swt/delphi/cli/commands/Command.scala 0% <0%> (ø) ⬆️
...la/de/upb/cs/swt/delphi/cli/commands/package.scala 0% <0%> (ø)
...e/upb/cs/swt/delphi/cli/commands/TestCommand.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee305e...7d8068a. Read the comment docs.

@delphi-hub delphi-hub deleted a comment Jan 25, 2019
@delphi-hub delphi-hub deleted a comment Jan 25, 2019
@delphi-hub delphi-hub deleted a comment Jan 25, 2019
@delphi-hub delphi-hub deleted a comment Jan 25, 2019
@delphi-hub delphi-hub deleted a comment Jan 25, 2019
@delphi-hub delphi-hub deleted a comment Jan 25, 2019
@delphi-hub delphi-hub deleted a comment Jan 25, 2019
build.sbt Outdated
@@ -1,6 +1,6 @@
scalaVersion := "2.12.4"

name := "delphi"
name := "delphi-cli"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to rename this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The executable generated will take this name. So I have renamed it. I can revert if it is a issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's why i actually renamed it. :)
This way the users can enter delphi and not delphi-cli.
I think this ways its a bit stronger. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then revert it to delphi. In documentation delphi-cli is used I renamed because of that https://github.com/delphi-hub/delphi-cli.

Copy link
Member

@bhermann bhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for code style issues and the question mentioned above. Thanks. 😄

@bhermann
Copy link
Member

@hariharansrc could you take care of this?

@hariharansrc
Copy link
Member Author

@bhermann Sorry I didn't not get any notification.I will do it now.

@bhermann
Copy link
Member

bhermann commented Mar 7, 2019

No worries... Thank you! :-)

1 similar comment
@bhermann
Copy link
Member

bhermann commented Mar 7, 2019

No worries... Thank you! :-)

@hariharansrc hariharansrc requested a review from bhermann March 7, 2019 18:06
@bhermann bhermann merged commit 1396373 into develop Mar 9, 2019
@ghost ghost removed the review label Mar 9, 2019
@bhermann bhermann deleted the Feature/27/NativeExe branch March 9, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants