-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/27/native exe #32
Conversation
Cool work! How fast is it? |
Codecov Report
@@ Coverage Diff @@
## develop #32 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 9 10 +1
Lines 200 199 -1
Branches 8 10 +2
=====================================
+ Misses 200 199 -1
Continue to review full report at Codecov.
|
build.sbt
Outdated
@@ -1,6 +1,6 @@ | |||
scalaVersion := "2.12.4" | |||
|
|||
name := "delphi" | |||
name := "delphi-cli" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to rename this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The executable generated will take this name. So I have renamed it. I can revert if it is a issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's why i actually renamed it. :)
This way the users can enter delphi
and not delphi-cli
.
I think this ways its a bit stronger. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then revert it to delphi
. In documentation delphi-cli
is used I renamed because of that https://github.com/delphi-hub/delphi-cli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check for code style issues and the question mentioned above. Thanks. 😄
@hariharansrc could you take care of this? |
@bhermann Sorry I didn't not get any notification.I will do it now. |
No worries... Thank you! :-) |
1 similar comment
No worries... Thank you! :-) |
Move away from akka http #27