add second device: warn about 3rd parties #3579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR adds a hint about making sure no 3rd party can see the "Add Second Device" QR code. the dialog and the hint are already used on all OS, so that is a low hanging fruit - (compared to other ideas of changing flow direction etc, which we might go for at some point; however, that would be lots of effort on all UI, is tricky UX wise, will come with new bugs and other cornercases, and are also not bullet save against careless users, "hey, scan my QR code ... no, from 'Add Second Device, Next, Next ...'" :)
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds a hint about making sure no 3rd party can see the "Add Second Device" QR code. the PR is the outcome of some community discussions.
the dialog and the hint are already used on all OS, so that is a low hanging fruit -
(compared to other ideas of changing flow direction etc, which we might go for at some point;
however, that would be lots of effort on all UI,
is tricky UX wise, will come with new bugs and other cornercases, and are also not bullet save against careless users, "hey, scan my QR code ... no, from 'Add Second Device, Next, Next ...'" :)
for easy adaption and not to do lots of subsequent things on all platforms, the PR is only about the wording, colors etc. are out of scope.