Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to edit message #3601

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

allow to edit message #3601

wants to merge 16 commits into from

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented Feb 19, 2025 •
edited
Loading

  • add new edit-message API to bindings
  • allow to edit outgoing text messages
  • mark edited message as edited
  • show "Edit Message" as quoted message author instead of "me"

image

@adbenitez adbenitez self-assigned this Feb 19, 2025
@adbenitez adbenitez changed the title add C bindings allow to edit message Feb 19, 2025
@adbenitez adbenitez added the wait-for-core Issue/PR is waiting for core release label Feb 20, 2025
@adbenitez adbenitez marked this pull request as ready for review February 20, 2025 01:30
@adbenitez adbenitez requested review from r10s and Hocuri February 20, 2025 01:30
r10s
r10s approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff! code lgtm, did not test yet, however.

as tag already says, merging needs to wait for core

@r10s r10s mentioned this pull request Feb 20, 2025
Draft
@r10s
Copy link
Member

r10s commented Feb 20, 2025 •
edited
Loading

very nice cleaned up menu.

  • if we keep "delete" in the overflow menu (i would give it a try!), please remove it to the end and make it red
  • for discoverability, and consistency with older deltas and whatsapp/signal/telelgram, let's keep "reply" at least in the overflow menu, before "reply privately" EDIT: it is already like that, i have overseen that somehow
  • not sure if "share" shouldn't be in the overflow menu as well

This was referenced Feb 21, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

@Hocuri Hocuri Awaiting requested review from Hocuri

Assignees

@adbenitez adbenitez

Labels
wait-for-core Issue/PR is waiting for core release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adbenitez @r10s