Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add specter docs #218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add specter docs #218

wants to merge 2 commits into from

Conversation

smuu
Copy link
Collaborator

@smuu smuu commented Jan 19, 2025

Summary by CodeRabbit

  • Documentation
    • Added a new documentation page for Specter Devnet.
    • Updated documentation summary to include Specter Devnet section.
    • Provided information about devnet versions, namespaces, and network endpoints.
    • Included guidance for users about development and testing purposes.
    • Added a troubleshooting section encouraging user feedback for improvements.

Copy link
Contributor

coderabbitai bot commented Jan 19, 2025

Walkthrough

A new documentation file specter-devnet.md has been added to the project's documentation, introducing information about the Prism Specter Devnet on Celestia's Mocha testnet. Simultaneously, the SUMMARY.md file has been updated to include a reference to this new document in the "Introduction" section, ensuring the new content is integrated into the documentation structure.

Changes

File Change Summary
doc/src/SUMMARY.md Added new entry [Specter Devnet](specter-devnet.md) in the Introduction section
doc/src/specter-devnet.md Created new documentation file describing Specter Devnet details, versions, namespaces, and endpoints

Poem

🐰 A Devnet Bunny's Delight

Hop, hop, through Celestia's testnet bright,
Specter Devnet springs to coding's height!
Namespaces dance, endpoints gleam,
Not for production, just a dev's dream
Testing, learning - our rabbit's delight! 🚀

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6bb3ac and 34ac01e.

📒 Files selected for processing (1)
  • doc/src/SUMMARY.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • doc/src/SUMMARY.md
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: unused dependencies
  • GitHub Check: integration-test
  • GitHub Check: unit-test
  • GitHub Check: clippy

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (3)
doc/src/specter-devnet.md (3)

1-3: Consider adding explicit security warning about mock proofs.

While the development/testing warning is clear, consider adding an explicit security warning about the implications of using mock proofs. This helps prevent misuse and potential security risks.

 # 👻 Specter Devnet: Enter the Haunted Realm 👻

-Welcome, valiant explorer, to the Prism Specter Devnet—your gateway to the powerful capabilities of the based rollup on Celestia's Mocha testnet. Proceed with caution! This devnet is currently populated with mock proofs and is intended solely for development and testing purposes. **It is not suitable for production use.** Please be aware that the Specter Devnet may undergo changes at any time, including breaking modifications that could affect your work.
+Welcome, valiant explorer, to the Prism Specter Devnet—your gateway to the powerful capabilities of the based rollup on Celestia's Mocha testnet. Proceed with caution! This devnet is currently populated with mock proofs and is intended solely for development and testing purposes. **It is not suitable for production use and offers no security guarantees due to the use of mock proofs.** Please be aware that the Specter Devnet may undergo changes at any time, including breaking modifications that could affect your work.

47-62: Enhance network endpoints section with operational details.

Consider adding important operational information:

  1. API rate limits and quotas
  2. Expected uptime/SLA
  3. Contact information for endpoint-specific issues
  4. Any authentication requirements

65-68: Expand troubleshooting section with common solutions.

Consider enhancing the troubleshooting section with:

  1. Common issues and their solutions
  2. Instructions for enabling debug logs
  3. Bug report template with required information
  4. Links to relevant Discord/community channels
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72e198d and e6bb3ac.

📒 Files selected for processing (2)
  • doc/src/SUMMARY.md (1 hunks)
  • doc/src/specter-devnet.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • doc/src/SUMMARY.md
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: unit-test
  • GitHub Check: integration-test
  • GitHub Check: unused dependencies

Comment on lines +18 to +20
Unlock the secrets of the Specter Devnet with this verifying key (for testing purposes only):
`L2ilppK59Kq3aAMB/wpxdVGaI53DHPMdY6fcRodyFaA=`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add context about the verifying key's format and usage.

The verifying key section would benefit from additional information about:

  1. The key's encoding format (base64)
  2. Instructions or examples of how to use this key
  3. Where this key should be configured

Comment on lines +39 to +41
## 🕸️ How to Use the Specter Devnet 🕸️

Coming soon: **Detailed instructions will soon materialize from the shadows. Stay tuned!**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical section marked as "Coming soon".

The "How to Use" section is essential for users to get started with the devnet. Consider:

  1. Adding basic usage instructions in this PR
  2. Creating a follow-up issue to track the detailed documentation
  3. Including temporary workarounds or references

Comment on lines +9 to +10
- **Celestia DA**: `e11cd71`
- **Prism**: `pr-205`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance version references with links and semantic versions.

The current version references using commit hash and PR number could be improved:

  1. Add links to the specific commits/PRs
  2. Include semantic versions where available
  3. Consider adding release tags instead of commit hashes
-- **Celestia DA**: `e11cd71`
-- **Prism**: `pr-205`
+- **Celestia DA**: [`e11cd71`](https://github.com/celestiaorg/celestia-node/commit/e11cd71) (v0.x.x)
+- **Prism**: [PR #205](https://github.com/deltadevsde/prism/pull/205) (upcoming v0.x.x)

Committable suggestion skipped: line range outside the PR's diff.

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
prism ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 8:11am

@distractedm1nd
Copy link
Contributor

Let's move this to the actual docs and then link to the docs. Will commit directly to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants